Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1-buster-slim breaks workflows using cdk v2.0.0-rc.25 #1173

Closed
ahammond opened this issue Oct 25, 2021 · 2 comments · Fixed by #1327 or #1338
Closed

1-buster-slim breaks workflows using cdk v2.0.0-rc.25 #1173

ahammond opened this issue Oct 25, 2021 · 2 comments · Fixed by #1327 or #1338

Comments

@ahammond
Copy link
Contributor

My PR's build is failing with

error @aws-cdk/assert@2.0.0-rc.25: The engine "node" is incompatible with this module. Expected version ">= 14.15.0". Got "12.22.7"

while trying to upgrade All The Things in my corp cdk-library.

❯ npx projen --version
0.27.51

One of the things I see is that the upgrade swapped:

      image: jsii/superchain:node14
      image: jsii/superchain:1-buster-slim

in the workflows. I don't know what 1-buster-slim is, but... it looks like it's breaking stuff.

Workaround in .projenrc.js:

  workflowContainerImage: 'jsii/superchain:node14', // Workaround buster-slim issue
@wchaws
Copy link

wchaws commented Dec 8, 2021

I met the same issue

@wchaws wchaws mentioned this issue Dec 8, 2021
Closed
@jeffgardnerdev
Copy link

I came across this same issue and I got around it by adding minNodeVersion: '14.17.0' to my .projenrc.js file.

@eladb eladb mentioned this issue Dec 13, 2021
Merged
eladb pushed a commit that referenced this issue Dec 14, 2021
fix(awscdk): some issues with CDK v2 (#1327)
61c47b5 
Extract the logic that handles CDK dependencies (and supports v1/v2 differences) into a new component called `AwsCdkDeps` and reuse across  `AwsCdkTypeScriptApp` and `AwsCdkConstructLibrary`.

* Modify `LambdaFunction` to determine how to render import statements in the generated function construct source code.
* Fix the sample test code in `awscdk-app-ts` to work with the new assertions library.
* Change the default CDK version for `awscdk-app-ts` to `^2`.
* Change `cdkVersion` and `constructsVersion` to reflect version requirement instead of a specific version. This means that existing projects will need to be migrated. Added a NOTICE message during synth to inform.
* Determines workflow container image based on CDK version

Fixes #1288 
Fixes #1326
Fixes #1173

BREAKING CHANGE: The `cdkVersion` and `constructsVersion` options are now *semver ranges* and not just specific versions. To enable the previous behavior, use a caret prefix `^`.
* **awscdk:** `LambdaFunction` and `AutoDiscover` now requires `cdkDeps` so they can interact with CDK version manager.
eladb pushed a commit that referenced this issue Dec 14, 2021
fix(awscdk): issues with CDK v2 in libraries and apps
fc137ae 
Extract the logic that handles CDK dependencies (and supports v1/v2 differences) into a new component called `AwsCdkDeps` and reuse across  `AwsCdkTypeScriptApp` and `AwsCdkConstructLibrary`.

* Modify `LambdaFunction` to determine how to render import statements in the generated function construct source code.
* Fix the sample test code in `awscdk-app-ts` to work with the new assertions library.
* Change the default CDK version for `awscdk-app-ts` to `2.1.0`.
* Determines workflow container image based on CDK version

Fixes #1288
Fixes #1326
Fixes #1173

BREAKING CHANGE: `LambdaFunction` and `AutoDiscover` now requires `cdkDeps` so they can interact with CDK version manager.
@eladb eladb mentioned this issue Dec 14, 2021
Merged
eladb pushed a commit that referenced this issue Dec 14, 2021
fix(awscdk): issues with CDK v2 libraries and apps (take 2) (#1338)
eb1283f 
Extract the logic that handles CDK dependencies (and supports v1/v2 differences) into a new component called `AwsCdkDeps` and reuse across  `AwsCdkTypeScriptApp` and `AwsCdkConstructLibrary`.

This is a follow up on #1327 which we had to revert due to breaking upgrade flows. The difference is that this change does NOT introduce breaking behavioral change to `cdkVersion` and dev/peer dependencies of constructs.

* Modify `LambdaFunction` to determine how to render import statements in the generated function construct source code.
* Fix the sample test code in `awscdk-app-ts` to work with the new assertions library.
* Change the default CDK version for `awscdk-app-ts` to `2.1.0`.
* Determines workflow container image based on CDK version

Fixes #1288
Fixes #1326
Fixes #1173

Co-authored-by: Christopher Rybicki <rybickic@amazon.com>
Co-authored-by: github-actions <github-actions@github.com>

BREAKING CHANGE: `LambdaFunction` and `AutoDiscover` now requires `cdkDeps` so they can interact with CDK version manager.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ahammond @jeffgardnerdev @wchaws