-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Support for private / non-default repositories #124
Comments
Sounds good! contributions are welcome |
Let's just add support for specifying the Regarding codeArtifact, given we have AWS credentials in a GitHub secret (which I am assuming are required for any solution), the workflow can do whatever it needs (like obtaining a token from aws). |
mergify bot
pushed a commit
that referenced
this issue
Oct 7, 2020
Issue #, if available: #124 Description of changes: This pull request will allow users to release to more than just the default twine repository such as CodeArtifact. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Resolved by #140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Currently it seems that Projen only supports the public repositories (npmjs.com, pypi.org, maven central).
This is controlled by
jsii-project.ts
:Proposed solution
Since
jsii-release
already supports settingNPM_REGISTRY
andTWINE_REPOSITORY_URL
this probably could be managed by allowing one to set values in.projenrc.js
:options.nodejs.defaultRegistry = false
to enableNPM_REGISTRY: '${{ secrets.NPM_REGISTRY }}',
options.python.defaultRegistry = false
to enableTWINE_REPOSITORY_URL: '${{ secrets.TWINE_REPOSITORY_URL }}',
Related AWS CodeArtifact issues
Then there's the issue of AWS CodeArtifact, which does not provide permanent token, but a temporary token which has a maximum duration of 12 hours (
43200
seconds). It would require having some extra step in the Github workflow which might not be that easy to support with projen 🤷♂️The text was updated successfully, but these errors were encountered: