Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the cdk8sPlusVersion option in cdk8s classes #1272

Closed
Hunter-Thompson opened this issue Nov 30, 2021 · 0 comments · Fixed by #1273
Closed

Deprecate the cdk8sPlusVersion option in cdk8s classes #1272

Hunter-Thompson opened this issue Nov 30, 2021 · 0 comments · Fixed by #1273

Comments

@Hunter-Thompson
Copy link
Contributor 

Error: Error: Declared dependency on version 1.0.0-beta.53 of cdk8s, but version 1.2.0 was found

Since cdk8s-plus-17 was deprecated, using any stable version of cdk8s or any version after 1.0.0-beta.53 results in a dependency issue.

If someone requires cdk8s plus installed they can add it to the dev/peer deps.
@Hunter-Thompson Hunter-Thompson mentioned this issue Nov 30, 2021
Merged
@mergify mergify bot closed this as completed in #1273 Dec 1, 2021
mergify bot pushed a commit that referenced this issue Dec 1, 2021
@Hunter-Thompson
fix(cdk8s): deprecate cdk8sPlusVersion option (#1273)
6532fc9 
REFACTOR: removes cdk8sPlusVersion options

Signed-off-by: Hunter Thompson <aatman@auroville.org.in>

Closes #1272 

BREAKING CHANGE: `cdk8s-plus` is not included automatically in cdk8s project. Users need to add this dependency explicitly.

---
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cdk8s): deprecate cdk8sPlusVersion option Hunter-Thompson/projen
1 participant
@Hunter-Thompson