Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to disable auto-merge #1765

Closed
sacharya-sp opened this issue Apr 13, 2022 · 2 comments · Fixed by #1783
Closed

No way to disable auto-merge #1765

sacharya-sp opened this issue Apr 13, 2022 · 2 comments · Fixed by #1783

Comments

@sacharya-sp
Copy link

Looks like the mergify configuration comes with an auto-merge rule by default, and there's no way to disable it. The option mergifyOptions has the ability to add additional auto-merge rules, but no way to remove the default rule.

I'm looking specifically at the AwsCdkTypeScriptApp project, but I'm seeing that this issue applies to other projects as well.

@Chriscbr
Copy link
Contributor

Hey @sacharya-sp - I did some digging and it looks like this rule is automatically added by a component named AutoMerge, but projen's API is missing a way to easily disable this.

Right now, the closest workaround is to specify mergify: false and then creating new Mergify(project, { ...options }) in your projenrc file.

We can easily add an option like autoMerge: false which will disable the creation of these default rules. Would that solve your issue more cleanly?

@sacharya-sp
Copy link
Author

Thanks Chris, this workaround works for me. It's a bit hard to find - it may not be apparent for other Projen users that the Mergify settings can be overridden by instantiating Mergify (rather than modifying the Project). An autoMerge option would certainly be easier to use for those who want to use Mergify without the default auto-merge rule.

@mergify mergify bot closed this as completed in #1783 Apr 21, 2022
mergify bot pushed a commit that referenced this issue Apr 21, 2022
Supersedes #1766
Fixes #1765

---
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants