Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are only a small subset of esbuild options exposed #3364

Closed
giseburt opened this issue Feb 14, 2024 · 0 comments · Fixed by #3366
Closed

There are only a small subset of esbuild options exposed #3364

giseburt opened this issue Feb 14, 2024 · 0 comments · Fixed by #3366

Comments

@giseburt
Copy link
Contributor

Building on the work from #3102 (merged as PR #3103), I'd like to add more esbuild options into the bundler. Looking at @aws-cdk-lib/aws-lambda-nodejs for inspiration.

Also, since we won't cover every option of esbuild possible in the future, we'll want an escape hatch as well.

I have a PR for this that I'll open shortly.
@giseburt giseburt mentioned this issue Feb 14, 2024
Merged
@mergify mergify bot closed this as completed in #3366 Feb 17, 2024
mergify bot pushed a commit that referenced this issue Feb 17, 2024
@giseburt
feat(bundler): additional esbuild options and generic escape hatch to…
482f782 
… pass any options to esbuild (#3366)

Fixes #3364

---
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@giseburt giseburt mentioned this issue Mar 13, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@giseburt