Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python)!: Poetry python project is using deprecated dev-dependencies notation in pyproject.toml #3375

Merged
merged 10 commits into from
Feb 24, 2024
Merged

fix(python)!: Poetry python project is using deprecated dev-dependencies notation in pyproject.toml #3375

merged 10 commits into from
Feb 24, 2024

Conversation

garysassano
Copy link
Contributor

@garysassano garysassano commented Feb 17, 2024

Poetry 1.2.0 introduced the group notation for managing dependencies, which has been the recommended way to organize dependencies inside your pyproject.toml file for almost two years. The older dev-dependencies notation was deprecated, as detailed here, and its use is discouraged.

BREAKING CHANGE: Poetry is now required to be at version 1.2.0 or above. Please update Poetry if needed.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@4d86588). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3375   +/-   ##
=======================================
  Coverage        ?   96.33%           
=======================================
  Files           ?      191           
  Lines           ?    37293           
  Branches        ?     3480           
=======================================
  Hits            ?    35926           
  Misses          ?     1367           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also mark this as a breaking change with a note how to resolve it (ie. upgrade poetry). Thanks!

@garysassano garysassano changed the title fix(python): update pyproject.toml structure for PythonProject using Poetry fix(python)!: update pyproject.toml structure for PythonProject using Poetry Feb 19, 2024
@mrgrain mrgrain changed the title fix(python)!: update pyproject.toml structure for PythonProject using Poetry fix(python)!: Poetry python project is using deprecated dev-dependencies notation in pyproject.toml Feb 21, 2024
src/toml.ts Outdated Show resolved Hide resolved
@mergify mergify bot merged commit a5f5672 into projen:main Feb 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants