fix(node): directory separators are inconsistent between platforms in tasks.json and package.json #3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
changed the title
mrgrain
approved these changes
Feb 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3387 +/- ##
=======================================
Coverage ? 96.33%
=======================================
Files ? 191
Lines ? 37299
Branches ? 3480
=======================================
Hits ? 35932
Misses ? 1367
Partials ? 0 ☔ View full report in Codecov by Sentry. |
mergify bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
…latforms in tasks.json and package.json (#3406) Related to #3284 (comment) This is the second attempt at fixing the directory separator issue for lambda entrypoints, which was started in #3387. I tried adding unit tests for `renderBundleName`. Unfortunately, this can't be unit-tested now because NodeJS exports the `path` package for the Linux platform instead of Windows at import time and not at runtime. https://github.com/nodejs/node/blob/f28ccd3941e70a825786eff7e28f59014ac76ac9/lib/path.js#L1546 I tested it locally in an example project, and it looks like it's fixed now.  --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3284 (comment)
Changelog
NodeProject.artifactsJavascriptDirectory, resulting indist\\jsbeing written on Windows instead ofdist/js.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.