fix(node): some directory separators are still inconsistent between platforms in tasks.json and package.json #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tasks.json and package.json, second attempt
gmeligio
force-pushed
the
lambda-subdir-posix
branch
from
210617c
to
9443f3e
Compare
mrgrain
changed the title
|
@gmeligio I assume this would be tested automatically once we start running builds on Windows? |
mrgrain
approved these changes
Feb 28, 2024
|
@gmeligio For some reason this broke the release: https://github.com/projen/projen/actions/runs/8079532064/job/22074128464#step:6:1035 Are you around to fix this forward? Otherwise I'll just revert the PR and we can try again. |
|
Sorry. Haven't had the time to look at it. I'll look into it in an hour or so. Go ahead and revert if necessary. |
|
No worries, turns out it got fixed via #3409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3284 (comment)
This is the second attempt at fixing the directory separator issue for lambda entrypoints, which was started in #3387.
I tried adding unit tests for
renderBundleName. Unfortunately, this can't be unit-tested now because NodeJS exports thepathpackage for the Linux platform instead of Windows at import time and not at runtime.https://github.com/nodejs/node/blob/f28ccd3941e70a825786eff7e28f59014ac76ac9/lib/path.js#L1546
I tested it locally in an example project, and it looks like it's fixed now.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.