-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker-compose): omit version if schemaVersion is not provided #3562
fix(docker-compose): omit version if schemaVersion is not provided #3562
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3562 +/- ##
========================================
Coverage 96.34% 96.35%
========================================
Files 192 192
Lines 37696 37738 +42
Branches 3524 2643 -881
========================================
+ Hits 36320 36364 +44
+ Misses 1376 1374 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Can you also @deprecated
the options please
Done! |
and then you'll have to update the generated API docs again |
All updated! |
The
version
element is deprecated in docker compose configs (https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-and-name-top-level-elements)This change omits
version
from thedocker-compose.yml
whenschemaVersion
isn't set. Not removing it completely to allow for backwards compatibility.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.