fix(license): apache license should not be modified #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the appendix from the Apache 2.0 license text. It's not required and not supposed to be edited. Fixes #830
Codecov Report
@@ Coverage Diff @@
## main #832 +/- ##
==========================================
+ Coverage 78.46% 83.53% +5.06%
==========================================
Files 88 99 +11
Lines 3181 3838 +657
Branches 809 904 +95
==========================================
+ Hits 2496 3206 +710
+ Misses 683 629 -54
- Partials 2 3 +1
Continue to review full report at Codecov.
|
I've checked some projects under https://github.com/apache/. They both have |
|
OK, reverting |
eladb
changed the title
wchaws
reviewed
May 30, 2021
added 3 commits
May 30, 2021 14:11
eladb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not modify the appendix in Apache 2.0 license. To allow other licenses to be modified (like MIT), change the substitution string to
$copyright_periodand$copyright_owner. If the text includes these tokens and the relevant options are not provided, fail.Fixes #830
BREAKING CHANGE: The initializer of the
Licensenow takesspdxthrough the options struct instead of a positional argument. Additionally, an error is thrown ifMITlicense is selected but thecopyrightOwneris not provided (because it is required in the license text).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.