fix(typescript): eslint task lints projenrcts #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1832 +/- ##
==========================================
+ Coverage 88.06% 93.59% +5.53%
==========================================
Files 132 158 +26
Lines 5109 27861 +22752
Branches 1207 2166 +959
==========================================
+ Hits 4499 26077 +21578
- Misses 610 1784 +1174
Continue to review full report at Codecov.
|
Chriscbr
reviewed
May 6, 2022
Chriscbr
approved these changes
May 9, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jun 13, 2022
Closes #1903 The change in #1832 inadvertently removed required configuration for files on `projenrc` to be linted. This change restores that config by once again creating the `ProjenrcTs` component _after_ the `Eslint` component. It also adds `projenrc` as a `testDir`, so files will be linted by the eslint task. This PR is aiming to resolve #1903 with minimal changes. I felt that the current implementation of the `Eslint` component is mixing responsibilities a bit (is it aware of projen, how much is it aware?) and makes some assumptions about what it thinks it knows about projen. **tl;dr I didn't really want to get into it.** But please let me know if you do want me to! --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1831
BREAKING CHANGE: EslintOptions.lintProjenRc is now a string
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.