fix(node): unable to run projen package on windows
#2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2761 +/- ##
==========================================
- Coverage 96.30% 96.28% -0.03%
==========================================
Files 181 181
Lines 33385 33407 +22
Branches 3062 3065 +3
==========================================
+ Hits 32153 32166 +13
- Misses 1232 1241 +9
|
Signed-off-by: github-actions <github-actions@github.com>
mrgrain
reviewed
Jun 29, 2023
src/cdk/jsii-project.package.task.ts
Outdated
Comment on lines
13
to
25
| if (process.env.CI) { | ||
| // in jsii we consider the entire repo (post build) as the build artifact | ||
| // which is then used to create the language bindings in separate jobs. | ||
| copyFiles(".", repoTempDir, [".git", "node_modules"]); | ||
| if (fs.existsSync(artifactsDirectory)) { | ||
| fs.rmdirSync(artifactsDirectory, { recursive: true }); | ||
| } | ||
| fs.renameSync(repoTempDir, artifactsDirectory); | ||
| } else { | ||
| child.execSync(`npx projen ${PACKAGE_ALL_TASK_NAME}`, { | ||
| stdio: ["inherit", "inherit", "inherit"], | ||
| }); | ||
| } |
There was a problem hiding this comment.
If this makes it any easier for you, I strongly believe that the if CI check should be done inside the GitHub Actions workflow (at which point it's not an if anymore) and not as part of the task.
But I realize you primarily want to fix this for windows. So this is still better than what we have today.
mergify bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
…ment (#3377) ## Motivation I was taking inspiration from #2761. I didn't closely follow what was available there because it's outdated, but I used a similar approach. There are different issues related to developing `projen` on Windows. The most related ones to bootstrapping are #1529 and #2427. To break the Windows development problem into pieces, I started with bootstraping because it is command I run the most run when developing projen. The other projen tasks can be reviewed and modified if necessary in future PRs. I should create an issue to expose this idea, but before doing that, I'm trying to see if breaking it like that is viable and starting with bootstrapping. ## Implementation I decided to do something similar to #2761 and use a NodeJS script. Then, I translated the existing Bash script, as of today, to NodeJS. Also, `.projenrc.js` will generate that script, similar to how it works with the existing Bash script. Windows has no CI implementation because the `build` and `package` tasks could fail. ## Changes ## Change 1 projen.js 1. The bootstrapping script is a translation from Bash to NodeJS. 2. The critical bits are the `bootstrap` and `execCommand` functions. 3. In `execCommand`, the important part is `{ stdio: "inherit" }` to make sure to pass input and get output from the executed command by passing down the parent process streams to the child process. 4. I didn't add tests. ## Change 2 .projenrc.js 1. Replacing `projen.bash` with `projen.js` 2. Adding functions in the entrypoint `.projenrc.js`: `execCommand` and `bootstrap`. These are only to simplify how `projen.js` is generated. Could it be better to move those two functions to another file so as not to pollute .projenrc.js? 4. I didn't add tests. ## Change 3 all files with marker 1. The marker was autoupdated to use `node ./projen.js` --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.