Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): Job Builder Class #3316

Closed
wants to merge 3 commits into from

Conversation

dkershner6
Copy link
Contributor

@dkershner6 dkershner6 commented Jan 31, 2024

Fixes #3315

Just a proposal, once we have a direction I will test and such.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dkershner6 dkershner6 marked this pull request as draft January 31, 2024 03:44
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 112 lines in your changes are missing coverage. Please review.

Comparison is base (db6ca4b) 96.39% compared to head (ed433dc) 96.12%.

Files Patch % Lines
src/github/workflow-job-builder.ts 67.44% 112 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3316      +/-   ##
==========================================
- Coverage   96.39%   96.12%   -0.27%     
==========================================
  Files         191      192       +1     
  Lines       36503    36828     +325     
  Branches     3403     3422      +19     
==========================================
+ Hits        35186    35401     +215     
- Misses       1317     1427     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrgrain
Copy link
Contributor

mrgrain commented Jan 31, 2024

Before you get into development, can you write (or update) a pseudo documentation page illustrating how this new API would be intended to be used? This might be better done and discussed on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Job interface made into or complemented with a class that has helpers to aid building a job
3 participants