Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): Adding Plugin Repository and Enhancing Repository Options #3534

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

awbdallas
Copy link
Contributor

  • Added Plugin Repositories
  • Added Maven Repository Policies
  • Added Tests

Links:

Fixes #


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Austin Briggs (Gitlab CI Runner) added 3 commits April 19, 2024 09:17
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (ad20d2c) to head (e655ad3).
Report is 15 commits behind head on main.

❗ Current head e655ad3 differs from pull request most recent head 3459c2a. Consider uploading reports for the commit 3459c2a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3534   +/-   ##
=======================================
  Coverage   96.34%   96.35%           
=======================================
  Files         192      192           
  Lines       37696    37740   +44     
  Branches     3524     3528    +4     
=======================================
+ Hits        36320    36366   +46     
+ Misses       1376     1374    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awbdallas awbdallas changed the title Adding Plugin Repository and Enhancing Repository Options feat(java): Adding Plugin Repository and Enhancing Repository Options Apr 19, 2024
@awbdallas awbdallas marked this pull request as ready for review April 19, 2024 18:30
@awbdallas
Copy link
Contributor Author

@mrgrain Any chance you can take a look?

/**
* Update Policy
*/
readonly updatePolicy?: "always" | "update" | "never" | `interval:${number}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be an enum like class, cause type unions don't translate well to java.

Comment on lines +171 to +176
readonly updatePolicy?: "always" | "update" | "never" | `interval:${number}`;

/**
* Checksum Policy
*/
readonly checksumPolicy?: "ignore" | "fail" | "warn";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be an enum like class, cause type unions don't translate well to java.

Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments. Rest looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants