-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(java): Adding Plugin Repository and Enhancing Repository Options #3534
base: main
Are you sure you want to change the base?
Conversation
- Added Plugin Repositories - Added Maven Repository Policies - Added Tests Links: - https://maven.apache.org/settings.html#repositories
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3534 +/- ##
=======================================
Coverage 96.34% 96.35%
=======================================
Files 192 192
Lines 37696 37740 +44
Branches 3524 3528 +4
=======================================
+ Hits 36320 36366 +46
+ Misses 1376 1374 -2 ☔ View full report in Codecov by Sentry. |
@mrgrain Any chance you can take a look? |
/** | ||
* Update Policy | ||
*/ | ||
readonly updatePolicy?: "always" | "update" | "never" | `interval:${number}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be an enum like class, cause type unions don't translate well to java.
readonly updatePolicy?: "always" | "update" | "never" | `interval:${number}`; | ||
|
||
/** | ||
* Checksum Policy | ||
*/ | ||
readonly checksumPolicy?: "ignore" | "fail" | "warn"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be an enum like class, cause type unions don't translate well to java.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments. Rest looks fine.
Links:
Fixes #
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.