feat(awscdk-construct): cdkDependenciesAsDeps #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miradorn
force-pushed
the
main
branch
2 times, most recently
from
afa5141
to
0cfee3e
Compare
eladb
changed the title
eladb
suggested changes
Mar 1, 2021
eladb
reviewed
Mar 1, 2021
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
eladb
reviewed
Mar 1, 2021
eladb
reviewed
Mar 1, 2021
|
@projen rebuild |
|
projen: Rebuild started |
eladb
approved these changes
Mar 1, 2021
eladb
changed the title
|
@Miradorn if using the new flag and installing CDK as devDeps and peerDeps, shouldn't the devDeps be pinned to guarantee a minimal version and the peerDeps are Currently both are unpinned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows disabling the default behavior in which CDK dependencies are also added as normal dependencies (and not just peer dependencies).
Resolves #577
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.