You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When importing a repo with proji, it uses the GitHub and GitLab API respectively to pull the informations about the specified repo. The GitHub and GitLab API are both limited to a certain number of requests per hour. For an unauthenticated user GitHub allows 60 requests per hour and 5000 for an authenticated user. Additionally private repos are currently unaccessible for proji beacuse of the missing authentication feature.
Describe the solution you'd like
Add the option for the user to authenticate himself with a GitHub and/or GitLab account. Ideally there should be an array in the main config for every hosting platform respectively which holds API relevant parameters.
Additional context
When the user reaches the rate limit both APIs return an error code 403. Proji should interpret this error code and return a well formatted description of why the request failed and calculate foe how long the user has to wait until he can use the API again.
Open for debate (comments welcome) - Should proji make authenticated API calls by default (in case that any auth relevant data was defined in the config at all) or ask the user every time if he wants to make an authenticated or unauthenticated API call? Maybe add an option in the main config which determines this behaviour? For example something like like use_api_auth_if_possible = true.
The text was updated successfully, but these errors were encountered:
I'm thinking about replacing the manual implementation of the GitHub and GitLab API by dedicated Go libraries. This would immediately solve the missing authentication feature, make it probably more stable and easier to maintain in the future since we don't have to react and adapt to changes in the GitHub/GitLab API ourselves.
Is your feature request related to a problem? Please describe.
When importing a repo with proji, it uses the GitHub and GitLab API respectively to pull the informations about the specified repo. The GitHub and GitLab API are both limited to a certain number of requests per hour. For an unauthenticated user GitHub allows 60 requests per hour and 5000 for an authenticated user. Additionally private repos are currently unaccessible for proji beacuse of the missing authentication feature.
Describe the solution you'd like
Add the option for the user to authenticate himself with a GitHub and/or GitLab account. Ideally there should be an array in the main config for every hosting platform respectively which holds API relevant parameters.
Relevant proji code:
Authentication docs:
Additional context
When the user reaches the rate limit both APIs return an error code 403. Proji should interpret this error code and return a well formatted description of why the request failed and calculate foe how long the user has to wait until he can use the API again.
Open for debate (comments welcome)- Should proji make authenticated API calls by default (in case that any auth relevant data was defined in the config at all) or ask the user every time if he wants to make an authenticated or unauthenticated API call? Maybe add an option in the main config which determines this behaviour? For example something like likeuse_api_auth_if_possible = true
.The text was updated successfully, but these errors were encountered: