Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds a test for empty json rpc response collections #66

Merged
merged 1 commit into from
Dec 5, 2017
Merged

adds a test for empty json rpc response collections #66

merged 1 commit into from
Dec 5, 2017

Conversation

oqq
Copy link
Contributor

@oqq oqq commented Dec 5, 2017 •
edited

I have found a bug with empty response collection in php 7.2 and would fix it.

But afterwards i have seen your changes on master branch. So here is the test I have already written for your changes. ;)

@coveralls
Copy link

coveralls commented Dec 5, 2017 •
edited

Coverage Status

Coverage decreased (-0.07%) to 91.294% when pulling a02994a on oqq:minor/empty_response_collection_test into b208d99 on prolic:master.

@prolic prolic merged commit c845101 into prolic:master Dec 5, 2017
@oqq oqq deleted the minor/empty_response_collection_test branch December 5, 2017 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prolic prolic prolic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oqq @coveralls @prolic