Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps update #18

Merged
merged 5 commits into from Jul 5, 2017
Merged

Deps update #18

merged 5 commits into from Jul 5, 2017

Conversation

prolic
Copy link
Owner

@prolic prolic commented Jul 4, 2017

resolves #16
superseeds #17

@Khartir I updated some components incl phpunit and enlarged the travis build matrix.

Currently 4 tests are failing, do you have time to check them?

1) HumusStreamResponseSenderTest\StreamResponseSenderTest::testSendHeadersAndStreamWithEnabledRangeSupportWithInvalidRangeStartHeader

Failed asserting that two strings are identical.

--- Expected

+++ Actual

@@ @@

-

+This is a sample file that will be streamed during the unit tests.

/home/travis/build/prolic/HumusStreamResponseSender/tests/HumusStreamResponseSenderTest/StreamResponseSenderTest.php:212

2) HumusStreamResponseSenderTest\StreamResponseSenderTest::testSendHeadersAndStreamWithEnabledRangeSupportWithInvalidRangeEndHeader

Failed asserting that two strings are identical.

--- Expected

+++ Actual

@@ @@

-

+This is a sample file that will be streamed during the unit tests.

/home/travis/build/prolic/HumusStreamResponseSender/tests/HumusStreamResponseSenderTest/StreamResponseSenderTest.php:234

3) HumusStreamResponseSenderTest\StreamResponseSenderTest::testSendHeadersAndStreamWithEnabledRangeSupportWithInvalidRangeStartAndEndHeader

Failed asserting that two strings are identical.

--- Expected

+++ Actual

@@ @@

-

+This is a sample file that will be streamed during the unit tests.

/home/travis/build/prolic/HumusStreamResponseSender/tests/HumusStreamResponseSenderTest/StreamResponseSenderTest.php:256

4) HumusStreamResponseSenderTest\StreamResponseSenderTest::testSendHeadersAndStreamWithEnabledRangeSupportWithInvalidRangeStartHeader2

Failed asserting that two strings are identical.

--- Expected

+++ Actual

@@ @@

-

+This is a sample file that will be streamed during the unit tests.

/home/travis/build/prolic/HumusStreamResponseSender/tests/HumusStreamResponseSenderTest/StreamResponseSenderTest.php:278

@coveralls
Copy link

coveralls commented Jul 4, 2017

Coverage Status

Coverage decreased (-1.1%) to 92.216% when pulling 56f42f5 on deps_update into 8854301 on master.

@Khartir Khartir mentioned this pull request Jul 4, 2017
@prolic prolic merged commit 56f42f5 into master Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last byte is never sent
3 participants