Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for strikethrough color #13

Merged
merged 2 commits into from
Mar 30, 2017
Merged

Conversation

htinlinn
Copy link
Contributor

No description provided.

@htinlinn htinlinn requested a review from jgsamudio March 30, 2017 14:41
Copy link
Contributor

@jgsamudio jgsamudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a test for color attributes?

@@ -161,6 +168,7 @@ public struct TextStyle {
self.textAlignment = textAlignment
self.lineBreakMode = lineBreakMode
self.strikethroughStyle = strikethroughStyle
self.strikethroughColor = strikethroughColor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the example project with the new color?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@htinlinn
Copy link
Contributor Author

@jgsamudio I think the attributes test should be in a separate PR. So far, there hasn't been any test for other attributes yet.

@htinlinn htinlinn merged commit a7bd62b into master Mar 30, 2017
@htinlinn htinlinn deleted the feature/strikethrough_color branch March 30, 2017 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants