Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added asynchronous dismissal of actions #24

Merged
merged 1 commit into from
Feb 17, 2016
Merged

Added asynchronous dismissal of actions #24

merged 1 commit into from
Feb 17, 2016

Conversation

Haud
Copy link
Contributor

@Haud Haud commented Feb 16, 2016

@MichaelCampbell
Copy link
Contributor

👍

@htinlinn
Copy link
Contributor

this looks good but was there any reason we have viewController as a property in YoshiActionResult instead of having it as an associated value in YoshiResult?

@Haud
Copy link
Contributor Author

Haud commented Feb 17, 2016

@htinlinn at this point, no. I can just refactor out YoshiActionResult and just have the function return YoshiResult. Would you guys want me to do that here or in a subsequent PR? This would be a breaking change.

@MichaelCampbell
Copy link
Contributor

I vote subsequent PR, @htinlinn?

@MichaelCampbell
Copy link
Contributor

@Haud Conflicts

@MichaelCampbell
Copy link
Contributor

still a 👍 for me

@htinlinn
Copy link
Contributor

alright. it makes sense to do this in a subsequent pr.

@htinlinn
Copy link
Contributor

👍

htinlinn added a commit that referenced this pull request Feb 17, 2016
@htinlinn
Merge pull request #24 from prolificinteractive/async_actions
7acb37b 
Added asynchronous dismissal of actions
@htinlinn htinlinn merged commit 7acb37b into master Feb 17, 2016
@htinlinn htinlinn deleted the async_actions branch February 17, 2016 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Haud @MichaelCampbell @htinlinn