Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generator: add game loading checks and testsuite #80

Merged
merged 8 commits into from
Feb 23, 2020
Merged

generator: add game loading checks and testsuite #80

merged 8 commits into from
Feb 23, 2020

Conversation

seirl
Copy link
Member

@seirl seirl commented Feb 18, 2020

No description provided.

@seirl seirl requested review from zopieux and Shaac February 18, 2020 06:18
@seirl seirl force-pushed the gen_wip_test branch 2 times, most recently from ed17360 to 0c0cbf7 Compare February 18, 2020 07:37
@seirl seirl mentioned this pull request Feb 23, 2020
Closed
20 tasks
zopieux
zopieux approved these changes Feb 23, 2020
View reviewed changes
Copy link
Member

@zopieux zopieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate validation code.

@seirl seirl merged commit aa4f2a3 into master Feb 23, 2020
@seirl seirl deleted the gen_wip_test branch February 23, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zopieux zopieux zopieux approved these changes

@Shaac Shaac Awaiting requested review from Shaac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seirl @zopieux