Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience overloads to isValid() #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonaskello
Copy link
Member

Fixes #54

@jonaskello
Copy link
Member Author

Not sure this is actually a good idea since internally the overloads will have to do error handling for invalid strings.

Now it is handled like this

  • Invalid PropertyValueSet string => exception becuase this is how fromString() works for PropertyValueSet
  • Invalid PropertyFilter string => Empty PropertyFilter

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 53.68% // Head: 53.71% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (9a4ced0) compared to base (889c1ea).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   53.68%   53.71%   +0.02%     
==========================================
  Files          49       49              
  Lines        2142     2156      +14     
  Branches      513      552      +39     
==========================================
+ Hits         1150     1158       +8     
- Misses        988      992       +4     
- Partials        4        6       +2     
Impacted Files Coverage Δ
packages/property/src/property-filter.ts 62.65% <60.00%> (-1.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

property: Add convenience overloads to isValid()
1 participant