add support for urls with query, clippy fixes #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, i need to add my own query parameters to urls but this library always assumes url has no query and uses
?
.Here is what botocore does: https://github.com/boto/botocore/blob/2cf64649cc020c2edcf28e22e6384750b5d8edb0/botocore/signers.py#L413
I copied that behavior, added new test and did a couple small clippy fixes