refactor!: Use pure Rust rather than link to OpenSSL #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
changed the title
|
Hey @cole-h , this got a bit lost in my notifications, I'm sorry. I just tested it and it looks like a great addition. Let's also change the README since we no longer need to depend on OpenSSL. In the meantime, can @nielstenboom maybe give me write access to the repo so that I can review/merge this? |
All the tests still pass, so this is at least equivalent to the previous content, but without the OpenSSL dependency. BREAKING CHANGE: This changes the type of `EncodingError::InvalidKeyError` and adds another variant.
|
No worries, I'm guilty of losing things in my notifications all the time, too 😆 I've amended the commit to drop the mentions of OpenSSL from the README altogether. Let me know if there's anything else you'd like for me to do! |
pevers
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the tests still pass, so this is at least equivalent to the previous content, but without the OpenSSL dependency.
BREAKING CHANGE: This changes the type of
EncodingError::InvalidKeyErrorand adds another variant.