Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Become a library #126

Open
jzelinskie opened this issue Mar 23, 2022 · 2 comments
Open

Become a library #126

jzelinskie opened this issue Mar 23, 2022 · 2 comments

Comments

@jzelinskie
Copy link

Hey there! The client half of this project looks super useful to embed into applications.
Does it make sense to move some of the logic out of the main package into something importable?
@SuperQ
Copy link
Contributor

SuperQ commented Mar 23, 2022

Sure, that sounds reasonable to me. Feel free to send PRs to move things out to a client package.

@LawyZheng
Copy link

I have forked this repo and rewritten it into a library and also embedded the client into the application rather than a service.
go to https://github.com/LawyZheng/promproxy to see more details, if you are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jzelinskie @SuperQ @LawyZheng