client: Use sane default values for the custom transport #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting up the custom transport for TLS support, the values for timeouts, keepalive, and connection counts are all defaulting to zero values. This can cause the client to not reconnect to a server that has become unavailable. Use the values of DefaultTransport in net/http to set up the custom transport with appropriate settings.
|
Thanks! |
giskou
pushed a commit
to giskou/PushProx
that referenced
this pull request
Apr 8, 2019
…community#45) When setting up the custom transport for TLS support, the values for timeouts, keepalive, and connection counts are all defaulting to zero values. This can cause the client to not reconnect to a server that has become unavailable. Use the values of DefaultTransport in net/http to set up the custom transport with appropriate settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up the custom transport for TLS support, the values for
timeouts, keepalive, and connection counts are all defaulting to zero
values. This can cause the client to not reconnect to a server that has
become unavailable.
Use the values of DefaultTransport in net/http to set up the custom
transport with appropriate settings.
Fixes #46.