Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: broken link to systemd exporter on docs #104

Merged
merged 1 commit into from
May 17, 2023

Conversation

jlosito
Copy link
Contributor

@jlosito jlosito commented May 14, 2023

This is a follow up to PR #102 .

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlosito
Copy link
Contributor Author

jlosito commented May 15, 2023

@gardar the step that failed apart of the workflow looks to be unrelated to this change. Is there anything I need to do to get this change merged?

@gardar
Copy link
Member

gardar commented May 15, 2023

The PR title should be in the format of fix: but otherwise it looks good.

In regards to the ansible-lint issue, I've proposed a fix in #106

@jlosito jlosito changed the title Fix broken link to systemd exporter on docs fix: broken link to systemd exporter on docs May 15, 2023
@gardar
Copy link
Member

gardar commented May 15, 2023

Or perphaps docs: would have been a better tag, but anyways, please rebase.

@gardar gardar changed the title fix: broken link to systemd exporter on docs docs: broken link to systemd exporter on docs May 15, 2023
@github-actions github-actions bot added trivial and removed bugfix labels May 15, 2023
@github-actions github-actions bot added trivial and removed trivial labels May 16, 2023
@jlosito
Copy link
Contributor Author

jlosito commented May 16, 2023

@gardar this should be rebased now.

@gardar
Copy link
Member

gardar commented May 16, 2023

Mind rebasing again? ansible-lint v6.16.1 update arrived this morning which caused additional lint errors, fixed in #109

Signed-off-by: John Losito <lositojohnj@gmail.com>
@jlosito
Copy link
Contributor Author

jlosito commented May 17, 2023

@gardar I've rebased again, and now the linter check is passing.

@gardar gardar merged commit c0d782c into prometheus-community:main May 17, 2023
37 checks passed
@jlosito jlosito deleted the broken-link branch May 24, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants