fix: textfile collector dir by setting recurse to false #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitz123
changed the title
fitz123
changed the title
fitz123
force-pushed
the
textfile_no_recurse
branch
from
caf59b6
to
a67dd7c
Compare
fitz123
changed the title
gardar
requested changes
May 15, 2023
There was a problem hiding this comment.
The default option for recurse is false, so we can just remove the parameter: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/file_module.html#parameter-recurse
Also, there is no need to link the PR as a comment since git does track it and you can just look at the commit history to see why it got removed.
gardar
changed the title
fitz123
force-pushed
the
textfile_no_recurse
branch
from
a67dd7c
to
4f8af41
Compare
fitz123
force-pushed
the
textfile_no_recurse
branch
from
4f8af41
to
79cb4f7
Compare
|
Linting errors were unrelated and have been fixed in main, please rebase. |
fitz123
force-pushed
the
textfile_no_recurse
branch
from
79cb4f7
to
a8ac73d
Compare
|
Err, a new version of ansible-lint was released this morning which brings us new linting issues. |
|
Mind rebasing again? Linting issues fixed in #109 |
… consistent ansible changes in case there are new metric files created by other users Signed-off-by: Anton Lugovoi <alugovoi@ordercapital.com>
fitz123
force-pushed
the
textfile_no_recurse
branch
from
a8ac73d
to
fddefac
Compare
gardar
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because it causes consistent ansible changes in case there are new metric files created by other users
fixes: #92