Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove references to to previous named ansible collection cloudalchemy #44

Conversation

andygrunwald
Copy link
Contributor

The repository is a migration from https://github.com/cloudalchemy/ansible-node-exporter. The previous repository has been marked as archived already.

@andygrunwald andygrunwald force-pushed the node-exporter-remove-cloudalchemy-reference branch from 144d5fa to c4ecab7 Compare March 5, 2023 10:13
@github-actions github-actions bot added trivial and removed trivial labels Mar 5, 2023
@gardar
Copy link
Member

gardar commented Mar 5, 2023

Thanks! Do you mind fixing the references to cloudalchemy in the other roles too?

@andygrunwald
Copy link
Contributor Author

@gardar Sure.
Most of the other references are demo code that includes things like

- demo.cloudalchemy.org:9100
- influx.cloudalchemy.org:9100

Do you prefer to keep it like this or to change those entries to something like

- demo.example.org:9100
- influx.example.org:9100

?

@gardar
Copy link
Member

gardar commented Mar 5, 2023

Actually what I was thinking was just the role names in the examples, like you have already proposed for node_exporter but apparently it's just the node_exporter and blackbox_exporter that has it.
But removing all references to cloudalchemy (and circleci) is something that needs to be done sooner or later, so if you're up to it - go ahead :)

I do believe those demos now live at: https://demo.do.prometheus.io/

@andygrunwald andygrunwald force-pushed the node-exporter-remove-cloudalchemy-reference branch from c4ecab7 to de4db61 Compare March 6, 2023 08:58
@github-actions github-actions bot added trivial and removed trivial labels Mar 6, 2023
…alchemy

The repository is a migration from https://github.com/cloudalchemy/ansible-node-exporter.
The previous repository has been marked as archived already.

Signed-off-by: Andy Grunwald <andygrunwald@gmail.com>
…different version scheme

Because the new library (kind of) starts from fresh, the upgrade notice is not relevant anymore.

Signed-off-by: Andy Grunwald <andygrunwald@gmail.com>
A few links to prometheus.io (escpecially config settings) have been broken.

Signed-off-by: Andy Grunwald <andygrunwald@gmail.com>
@andygrunwald andygrunwald force-pushed the node-exporter-remove-cloudalchemy-reference branch from de4db61 to afef336 Compare March 6, 2023 08:59
@github-actions github-actions bot added trivial and removed trivial labels Mar 6, 2023
@andygrunwald
Copy link
Contributor Author

@gardar Done.

I have

Let me know what you think and if anything is missing.

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ requested a review from gardar March 6, 2023 09:09
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thanks.

@gardar gardar merged commit 463ab2c into prometheus-community:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants