Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set port to 8053 in BIND configuration example, fix typos #36

Merged
merged 2 commits into from Mar 7, 2018

Conversation

elnappo
Copy link
Contributor

@elnappo elnappo commented Mar 3, 2018

No description provided.

@elnappo elnappo changed the title Set port to 8053 in BIND configuration example Set port to 8053 in BIND configuration example, fix typos Mar 4, 2018
@cagedmantis
Copy link
Contributor

Thank you for this submission @elnappo

@@ -22,7 +22,7 @@ bind_exporter next to BIND, so it's only necessary to open a port locally.

```
statistics-channels {
inet 127.0.0.1 port 8080 allow { 127.0.0.1; };
inet 127.0.0.1 port 8053 allow { 127.0.0.1; };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port 8080 seems like the default bind statistics port. Do you have a compelling reason for this change?

@elnappo
Copy link
Contributor Author

elnappo commented Mar 7, 2018

I've changed it based on https://github.com/digitalocean/bind_exporter/blob/master/bind_exporter.go#L438 and #24 (comment)

I'm not sure if there is something like a "default" port. BINDs documentation mentions port 8888 (https://ftp.isc.org/isc/bind9/cur/9.10/doc/arm/Bv9ARM.ch06.html#statistics), some how-tos/tools are using 8080 (https://kb.isc.org/article/AA-00769/0/Using-BINDs-XML-statistics-channels.html) or 8053 (https://collectd.org/wiki/index.php/Plugin:BIND).

It does not matter for me which port is the "default" port, but it should be consistent between README.md and the actual default value for the port flag.

@cagedmantis
Copy link
Contributor

lgtm

@cagedmantis cagedmantis merged commit 38ef3a6 into prometheus-community:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants