Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix role detection #110

Merged
merged 1 commit into from
Nov 27, 2017
Merged

Conversation

dominikschulz
Copy link
Contributor

This PR adds some more test cases for a multi-node 5.5.0 cluster and fixes the role detection.

Fixes #109

This PR adds some more test cases for a multi-node 5.5.0 cluster and fixes the role detection.

Fixes prometheus-community#109
Copy link
Member

@zwopir zwopir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. We should later on add test cases for the 1.7 and 2.x roles

@zwopir zwopir merged commit 762afe1 into prometheus-community:master Nov 27, 2017
@dominikschulz dominikschulz deleted the fix/issue-109 branch November 27, 2017 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.0.2.rc2] ES role shows the same on all nodes
2 participants