Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index metrics #116

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Add index metrics #116

merged 1 commit into from
Jan 9, 2018

Conversation

dominikschulz
Copy link
Contributor

Fixes #115

@dominikschulz dominikschulz added this to the 1.0.2 milestone Dec 20, 2017
zwopir
zwopir approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@zwopir zwopir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - just a small typo in the help

collector/indices.go Outdated
Type: prometheus.GaugeValue,
Desc: prometheus.NewDesc(
prometheus.BuildFQName(namespace, "indices", "segment_count_primary"),
"Current number of segements with only primary shards on all nodes",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/segements/segments/g (not only here)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching! Will update the PR after lunch.

@dominikschulz dominikschulz self-assigned this Dec 20, 2017
@dominikschulz dominikschulz merged commit 4cab830 into prometheus-community:master Jan 9, 2018
@dominikschulz dominikschulz deleted the feature/issue-115 branch January 9, 2018 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwopir zwopir zwopir approved these changes

Assignees

@dominikschulz dominikschulz

Labels
enhancement
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dominikschulz @zwopir