Add HTTP/TCP connections and Swap/Recovery metrics #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anti-social
reviewed
Nov 24, 2020
Comment on lines
+290
to
+325
| { | ||
| Type: prometheus.GaugeValue, | ||
| Desc: prometheus.NewDesc( | ||
| prometheus.BuildFQName(namespace, "os", "swap_in_bytes_used"), | ||
| "Amount of used swap space in bytes", | ||
| defaultNodeLabels, nil, | ||
| ), | ||
| Value: func(node NodeStatsNodeResponse) float64 { | ||
| return float64(node.OS.Swap.Used) | ||
| }, | ||
| Labels: defaultNodeLabelValues, | ||
| }, | ||
| { | ||
| Type: prometheus.GaugeValue, | ||
| Desc: prometheus.NewDesc( | ||
| prometheus.BuildFQName(namespace, "os", "swap_in_bytes_free"), | ||
| "Amount of free swap space in bytes", | ||
| defaultNodeLabels, nil, | ||
| ), | ||
| Value: func(node NodeStatsNodeResponse) float64 { | ||
| return float64(node.OS.Swap.Free) | ||
| }, | ||
| Labels: defaultNodeLabelValues, | ||
| }, | ||
| { | ||
| Type: prometheus.GaugeValue, | ||
| Desc: prometheus.NewDesc( | ||
| prometheus.BuildFQName(namespace, "os", "swap_in_bytes_total"), | ||
| "Total amount of swap space in bytes", | ||
| defaultNodeLabels, nil, | ||
| ), | ||
| Value: func(node NodeStatsNodeResponse) float64 { | ||
| return float64(node.OS.Swap.Total) | ||
| }, | ||
| Labels: defaultNodeLabelValues, | ||
| }, |
There was a problem hiding this comment.
Think these metrics should be named swap_used_bytes, swap_free_bytes & swap_total_bytes simalarly to mem_* metrics.
anti-social
reviewed
Nov 24, 2020
| @@ -1510,6 +1558,30 @@ func NewNodes(logger log.Logger, client *http.Client, url *url.URL, all bool, no | |||
| }, | |||
| Labels: defaultNodeLabelValues, | |||
| }, | |||
| { | |||
| Type: prometheus.CounterValue, | |||
There was a problem hiding this comment.
Number of current open connections should be a gauge.
anti-social
reviewed
Nov 24, 2020
Comment on lines
+1563
to
+1584
| Desc: prometheus.NewDesc( | ||
| prometheus.BuildFQName(namespace, "http", "connections_opened_current"), | ||
| "Current number of opened connections", | ||
| defaultNodeLabels, nil, | ||
| ), | ||
| Value: func(node NodeStatsNodeResponse) float64 { | ||
| return float64(node.HTTP.CurrentOpen) | ||
| }, | ||
| Labels: defaultNodeLabelValues, | ||
| }, | ||
| { | ||
| Type: prometheus.CounterValue, | ||
| Desc: prometheus.NewDesc( | ||
| prometheus.BuildFQName(namespace, "http", "connections_opened_total"), | ||
| "Total number of opened connections", | ||
| defaultNodeLabels, nil, | ||
| ), | ||
| Value: func(node NodeStatsNodeResponse) float64 { | ||
| return float64(node.HTTP.TotalOpen) | ||
| }, | ||
| Labels: defaultNodeLabelValues, | ||
| }, |
There was a problem hiding this comment.
Why do you think it's worth to rename Elasticsearch's metrics? This makes harder matching exporter's metric to the origin.
anti-social
added a commit
to anti-social/json-exporter
that referenced
this pull request
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following metrics:
elasticsearch_indices_recovery_current_as_sourceelasticsearch_indices_recovery_current_as_targetelasticsearch_indices_recovery_throttle_time_seconds_totalelasticsearch_os_swap_in_bytes_usedelasticsearch_os_swap_in_bytes_freeelasticsearch_os_swap_in_bytes_totalelasticsearch_transport_tcp_connections_opened_totalelasticsearch_http_connections_opened_currentelasticsearch_http_connections_opened_total