Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup non-standard ENV var setup #518

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Cleanup non-standard ENV var setup #518

merged 1 commit into from
Jan 19, 2022

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Jan 19, 2022

Drop ENV vars from flags as this is non-standard in the Prometheus
ecosystem.

Signed-off-by: SuperQ superq@gmail.com

main.go Show resolved Hide resolved
@sysadmind
Copy link
Contributor

After this PR gets merged, I think there are a few things that should follow. Adding them here just as a note.

  • Remove the user/password support from ES_URI. Update docs accordingly.
  • Vars for the helm chart will need to change. This helm chart probably needs a new home. Is the prometheus-community/helm-charts a good repo?

@SuperQ SuperQ force-pushed the bjk/fixup_env branch 2 times, most recently from 75a2418 to 35d92a5 Compare January 19, 2022 16:36
@SuperQ
Copy link
Contributor Author

SuperQ commented Jan 19, 2022

Drop ENV vars from flags as this is non-standard in the Prometheus
ecosystem.
* Remove es.apiKey flag to avoid credential leaks.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ merged commit 45e0d70 into master Jan 19, 2022
@SuperQ SuperQ deleted the bjk/fixup_env branch January 19, 2022 17:36
iishabakaev pushed a commit to iishabakaev/elasticsearch_exporter that referenced this pull request Jun 8, 2022
Drop ENV vars from flags as this is non-standard in the Prometheus
ecosystem.
* Remove es.apiKey flag to avoid credential leaks.

Signed-off-by: SuperQ <superq@gmail.com>
@perlun
Copy link
Contributor

perlun commented Sep 2, 2022

No offence, but changes like this should never make it into a minor release (1.4.0) like this. It goes against the very foundation of the SemVer philosophy. 😐

It's fine to make changes like this, but please, please try to do a major version bump in the future. It's much better for everybody that way. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants