Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update process CPU metric #520

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Update process CPU metric #520

merged 1 commit into from
Jan 19, 2022

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Jan 19, 2022

With PR #498, we only have one process CPU metric.

  • Drop the label.
  • Update the name to match Prometheus naming.

Signed-off-by: SuperQ superq@gmail.com

With PR #498, we only have one process CPU metric.
* Drop the label.
* Update the name to match Prometheus naming.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ requested a review from sysadmind January 19, 2022 12:27
@SuperQ
Copy link
Contributor Author

SuperQ commented Jan 19, 2022

CC @multani, followup to your change.

@multani
Copy link
Contributor

multani commented Jan 19, 2022

Thanks for the heads up @SuperQ, looks good to me 👍

Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysadmind sysadmind merged commit 4699efb into master Jan 19, 2022
@sysadmind sysadmind deleted the superq/cpu_total branch January 19, 2022 14:41
iishabakaev pushed a commit to iishabakaev/elasticsearch_exporter that referenced this pull request Jun 8, 2022
With PR prometheus-community#498, we only have one process CPU metric.
* Drop the label.
* Update the name to match Prometheus naming.

Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: iishabakaev <iishabakaev@gmail.com>
jnadler pushed a commit to jnadler/elasticsearch_exporter that referenced this pull request Oct 27, 2022
With PR prometheus-community#498, we only have one process CPU metric.
* Drop the label.
* Update the name to match Prometheus naming.

Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants