Fix index field count #675
Conversation
There was a problem hiding this comment.
You're missing the DCO. The check has instructions for how to fix.
I'm not sure this takes into account a situation where both type and properties are set. I'm not sure if these are mutually exclusive, but if not these would potentially double count those fields.
|
@sysadmind , thank you for the quick feedback. I will address those required changes you pointed out. As for counting a mapping where both type and property are set, although the type Having said that, the possibility is a valid edge case that should be accounted for, so I'll go ahead and make the modification to take that into account. Thank you for bringing that up. |
…indices_mappings feature Signed-off-by: Alain Lefebvre <hartfordfive@gmail.com>
Signed-off-by: Alain Lefebvre <hartfordfive@gmail.com>
… field is set to object as it will be counted in the recursion case Signed-off-by: Alain Lefebvre <hartfordfive@gmail.com>
Signed-off-by: Alain Lefebvre <hartfordfive@gmail.com>
hartfordfive
force-pushed
the
fix-index-field-count
branch
from
183ea6a
to
7e902c1
Compare
BREAKING CHANGES: The flag `--es.cluster_settings` has been renamed to `--collector.clustersettings`. * [CHANGE] Rename --es.cluster_settings to --collector.clustersettings * [FEATURE] Add ILM metrics #513 * [ENHANCEMENT] Add ElasticCloud node roles to role label #652 * [ENHANCEMENT] Add ability to use AWS IAM role for authentication #653 * [ENHANCEMENT] Add metric for index replica count #483 * [BUGFIX] Set elasticsearch_clusterinfo_version_info guage to 1 #728 * [BUGFIX] Fix index field counts with nested fields #675 --------- Signed-off-by: Joe Adams <github@joeadams.io>
This change applies a small modification that adds 1 to the field count prior to recursively counting the other nested fields in the mapping. (Issue #674)