Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add elasticsearch_indices_settings_shards metric doc (#806) #807

Closed
wants to merge 3 commits into from

Conversation

ichar0
Copy link

@ichar0 ichar0 commented Nov 3, 2023

Add monitoring indicators for number_of_shards #806

Test Results
#HELP elasticsearch_indices_settings_shards index setting number_of_shards
#TYPE elasticsearch_indices_settings_shards gauge
elasticsearch_indices_settings_shards{index=".monitoring-es-7-2023.10.27"} 1
elasticsearch_indices_settings_shards{index=".monitoring-es-7-2023.10.28"} 1

@ichar0
Copy link
Author

ichar0 commented Nov 14, 2023

@sysadmind hi, would it be possible to review this?

@sysadmind
Copy link
Contributor

Code looks fine, but it's missing the DCO. Details here: https://github.com/prometheus-community/elasticsearch_exporter/pull/807/checks?check_run_id=18324305490

@ichar0 ichar0 closed this Nov 15, 2023
@ichar0 ichar0 deleted the issue/806 branch November 15, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants