Skip to content

Commit

Permalink
[kube-prometheus-stack] Fix incorrect values.yaml descriptions (#3040)
Browse files Browse the repository at this point in the history
* [kube-prometheus-stack] fix values.yaml description

Signed-off-by: Maximilian Wipplinger <m.wipplinger@ftapi.com>

* [kube-prometheus-stack] bump chart version

Signed-off-by: Maximilian Wipplinger <m.wipplinger@ftapi.com>

* [kube-prometheus-stack] bump chart version

Signed-off-by: Maximilian Wipplinger <m.wipplinger@ftapi.com>

---------

Signed-off-by: Maximilian Wipplinger <m.wipplinger@ftapi.com>
Signed-off-by: Maximilian Wipplinger <85169503+mwipplinger-ftapi@users.noreply.github.com>
  • Loading branch information
mwipplinger-ftapi committed Apr 14, 2023
1 parent bd49f35 commit 8b445e4
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 11 deletions.
2 changes: 1 addition & 1 deletion charts/kube-prometheus-stack/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ name: kube-prometheus-stack
sources:
- https://github.com/prometheus-community/helm-charts
- https://github.com/prometheus-operator/kube-prometheus
version: 45.10.0
version: 45.10.1
appVersion: v0.63.0
kubeVersion: ">=1.16.0-0"
home: https://github.com/prometheus-operator/kube-prometheus
Expand Down
25 changes: 15 additions & 10 deletions charts/kube-prometheus-stack/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2780,11 +2780,12 @@ prometheus:
##
query: {}

## Namespaces to be selected for PrometheusRules discovery.
## If nil, select own namespace. Namespaces to be selected for ServiceMonitor discovery.
## See https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md#namespaceselector for usage
##
## If nil, select own namespace. Namespaces to be selected for PrometheusRules discovery.
ruleNamespaceSelector: {}
## Example which selects PrometheusRules in namespaces with label "prometheus" set to "somelabel"
# ruleNamespaceSelector:
# matchLabels:
# prometheus: somelabel

## If true, a nil or {} value for prometheus.prometheusSpec.ruleSelector will cause the
## prometheus resource to be created with selectors based on values in the helm deployment,
Expand Down Expand Up @@ -2849,10 +2850,12 @@ prometheus:
# matchLabels:
# prometheus: somelabel

## Namespaces to be selected for PodMonitor discovery.
## See https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md#namespaceselector for usage
##
## If nil, select own namespace. Namespaces to be selected for PodMonitor discovery.
podMonitorNamespaceSelector: {}
## Example which selects PodMonitor in namespaces with label "prometheus" set to "somelabel"
# podMonitorNamespaceSelector:
# matchLabels:
# prometheus: somelabel

## If true, a nil or {} value for prometheus.prometheusSpec.probeSelector will cause the
## prometheus resource to be created with selectors based on values in the helm deployment,
Expand All @@ -2869,10 +2872,12 @@ prometheus:
# matchLabels:
# prometheus: somelabel

## Namespaces to be selected for Probe discovery.
## See https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md#namespaceselector for usage
##
## If nil, select own namespace. Namespaces to be selected for Probe discovery.
probeNamespaceSelector: {}
## Example which selects Probe in namespaces with label "prometheus" set to "somelabel"
# probeNamespaceSelector:
# matchLabels:
# prometheus: somelabel

## How long to retain metrics
##
Expand Down

1 comment on commit 8b445e4

@OneCricketeer
Copy link

@OneCricketeer OneCricketeer commented on 8b445e4 Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one was missed for ruleNamespaceSelector in ThanosRuler spec

Please sign in to comment.