Skip to content

Commit

Permalink
alertmanager: add baseURL value (#4521)
Browse files Browse the repository at this point in the history
While using `extraArgs` is possible, `baseURL` is consistent with the
Prometheus chart and is more discoverable.
The template modification is taken from the prometheus chart.

Signed-off-by: Max Gautier <mg@max.gautier.name>
  • Loading branch information
VannTen committed May 8, 2024
1 parent 7d50bd5 commit f29a258
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/alertmanager/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ icon: https://raw.githubusercontent.com/prometheus/prometheus.github.io/master/a
sources:
- https://github.com/prometheus/alertmanager
type: application
version: 1.10.0
version: 1.11.0
appVersion: v0.27.0
kubeVersion: ">=1.19.0-0"
keywords:
Expand Down
3 changes: 3 additions & 0 deletions charts/alertmanager/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ spec:
{{- range $key, $value := .Values.extraArgs }}
- --{{ $key }}={{ $value }}
{{- end }}
{{- if .Values.baseURL }}
- --web.external-url={{ .Values.baseURL }}
{{- end }}
ports:
- name: http
containerPort: 9093
Expand Down
8 changes: 8 additions & 0 deletions charts/alertmanager/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,14 @@
"description": "Container image parameters.",
"$ref": "#/definitions/image"
},
"baseURL": {
"description": "External URL where alertmanager is reachable.",
"type": "string",
"default": "",
"examples": [
"https://alertmanager.example.com"
]
},
"extraArgs": {
"description": "Additional alertmanager container arguments. Use args without '--', only 'key: value' syntax.",
"type": "object",
Expand Down
3 changes: 3 additions & 0 deletions charts/alertmanager/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ image:
# Overrides the image tag whose default is the chart appVersion.
tag: ""

# Full external URL where alertmanager is reachable, used for backlinks.
baseURL: ""

extraArgs: {}

## Additional Alertmanager Secret mounts
Expand Down

0 comments on commit f29a258

Please sign in to comment.