Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] 57.2.0 include broken kube-state-metrics #4410

Closed
mcantinqc opened this issue Apr 2, 2024 · 3 comments · Fixed by #4419
Closed

[kube-prometheus-stack] 57.2.0 include broken kube-state-metrics #4410

mcantinqc opened this issue Apr 2, 2024 · 3 comments · Fixed by #4419
Labels
bug Something isn't working

Comments

@mcantinqc
Copy link

mcantinqc commented Apr 2, 2024

Describe the bug a clear and concise description of what the bug is.

The latest version of kube-prometheus-stack update the dependency kube-state-metrics to version 5.18.0 that include the version 2.11.0 of kube-state-metrics.

The version 2.11.0 is invalid with prometheus : kubernetes/kube-state-metrics#2270.

What's your helm version?

57.2.0

What's your kubectl version?

v1.29.1

Which chart?

kube-prometheus-stack

What's the chart version?

57.2.0

What happened?

Prometheus scrape fail with with invalid metric type "info".

See kubernetes/kube-state-metrics#1973

What you expected to happen?

Add a warning to https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-57.2.0 or rollback kube-state-metrics.

How to reproduce it?

No response

Enter the changed values of values.yaml?

No response

Enter the command that you execute and failing/misfunctioning.

n/a

Anything else we need to know?

No response

@mcantinqc mcantinqc added the bug Something isn't working label Apr 2, 2024
@cdenneen
Copy link

cdenneen commented Apr 4, 2024

With the release of 5.18.1 of kube-state-metrics can this helm-chart be bumped so its distributed package has the latest kube-state-metrics instead of 5.18.0

@cdenneen
Copy link

cdenneen commented Apr 5, 2024

@dotdc anyway we can get a release to close out this issue?

@dotdc
Copy link
Member

dotdc commented Apr 6, 2024

Hi @cdenneen,

Made PR #4419 to force a release.
Should fix the issue once merged.

In the meantime, you can configure your kube-prometheus-stack values to use the latest ksm image:

kube-state-metrics:
  image:
    tag: "2.12.0"

kingdonb added a commit to kingdonb/flux2-monitoring-example that referenced this issue Apr 10, 2024
prometheus-community/helm-charts#4410 (comment)
Thanks 🙏

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>
kingdonb added a commit to kingdonb/flux2-monitoring-example that referenced this issue May 13, 2024
Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>

add image controller

Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>

refactor-1 image controller

Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>

add image automation for bootstrap-repo

default namespace

Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>

new policy

Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>

remove tests

try version 56

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>

was this broken in 57.0.0 or a later patch release

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>

try 57.1.0

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>

57.2.0

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>

so 57.1.1 could still work theoretically

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>

this version did not work 57.2.0

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>

test the fix suggested by dotdc

prometheus-community/helm-charts#4410 (comment)
Thanks 🙏

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>

try tag v2.12.0

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>

revert kube-state-metrics v2.12.0 test

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>

can go as high as 57.1.1

Signed-off-by: Kingdon P Barrett <kingdon@tuesdaystudios.com>

Replace deprecated loki-stack with loki+promtail helm charts

Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

don't set storage: filesystem

Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>

persistence: enable: false

Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>

volumeClaimsEnabled

Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>

test 58.0.x again

Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants