Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] ServiceAccount is not created when RBAC creation is set to false in prometheus-operator/admission-webhooks/job-patch #4553

Closed
rgaduput opened this issue May 23, 2024 · 0 comments · Fixed by #4554
Labels
bug Something isn't working

Comments

@rgaduput
Copy link
Contributor

rgaduput commented May 23, 2024

Describe the bug a clear and concise description of what the bug is.

When rbac resources creation is set to false global.rbac.create, serviceAccount of prometheus-operator/admission-webhooks/job-patch is being skipped also.
This behavior is different than rest of the chart. For example in prometheus-operator rbac and serviceAccount are separated.

What's your helm version?

v3.10.2

What's your kubectl version?

v1.28.6

Which chart?

kube-prometheus-stack

What's the chart version?

42.3.0

What happened?

ServiceAccount creation is skipped.

What you expected to happen?

ServiceAccount is created.

How to reproduce it?

helm template or install with --set global.rbac.create=false

Enter the changed values of values.yaml?

global:
rbac:
create: false

Enter the command that you execute and failing/misfunctioning.

helm install kube-prom-stack prometheus-community/kube-prometheus-stack --version 42.3.0 --set global.rbac.create=false

Anything else we need to know?

No response

@rgaduput rgaduput added the bug Something isn't working label May 23, 2024
@rgaduput rgaduput changed the title [kube-prometheus-stack] ServiceAccount is not created when RBAC creation is set to false in prometheus-operator/admission-webhooks [kube-prometheus-stack] ServiceAccount is not created when RBAC creation is set to false in prometheus-operator/admission-webhooks/job-patch May 23, 2024
rgaduput added a commit to rgaduput/helm-charts that referenced this issue May 23, 2024
…ks/job-patch from the rbac creation (prometheus-community#4553)

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
rgaduput added a commit to rgaduput/helm-charts that referenced this issue May 23, 2024
…eus-operator/admission-webhooks/job-patch/serviceaccount (prometheus-community#4553)

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant