[kube-prometheus-stack] Use sub-chart ServiceMonitors #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is dependent on #1591 and re-running |
stevehipwell
force-pushed
the
kps-use-subchart-monitors
branch
from
5ebbbc1
to
9f52be0
Compare
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
stevehipwell
force-pushed
the
kps-use-subchart-monitors
branch
from
9f52be0
to
a405dba
Compare
stevehipwell
requested review from
bismarck,
gianrubio,
gkarthiks,
scottrigby and
Xtigyro
as code owners
|
/assign @monotek |
mrueg
approved these changes
Dec 17, 2021
Xtigyro
approved these changes
Dec 18, 2021
3 tasks
3 tasks
6 tasks
stamzid
pushed a commit
to Unstructured-IO/prometheus-community-helm-charts
that referenced
this pull request
Mar 3, 2023
…munity#1593) Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR switches to using the sub-chart
ServiceMonitorsfor kube-state-metrics and prometheus-node-exporter.Which issue this PR fixes:
Fixes #1425.
Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter])