-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheus] Add extra manifest templates #2140
[prometheus] Add extra manifest templates #2140
Conversation
Resolves: prometheus-community#2139 Signed-off-by: Yu Kato <yu-kato@colopl.co.jp>
@zanhsieh Have a question about the functionality in this PR This PR 2140 then extended on it with template based variation PR 2294 then did exactly the same functionality as 2044 while removing the functionality of this PR 2140 Was this an intentional decision to remove the functionality? |
@monotek That was the expectation, However we are not able to get template from previous changes to work on the new variation Would you be able to provide additional guidance on how to get this to work with new mechanism or point in a direction on how to get this working Help would be appreciated
The files being loaded in basic form look as follows
Edit: code block is not rendering indentation properly |
You have to use "```" for codeblocks. Current value shuld be "extraManifests" not "extraTemplates". |
@monotek Please ignore the value name, it was an excerpt from current implementation on our side
|
Signed-off-by: Yu Kato yu-kato@colopl.co.jp
What this PR does / why we need it:
This PR offers to deploy extra manifests, which includes any template inside prometheus helper.
When we want to deploy extra manifests using template helper the chart provides,
server.extraObjects
does not help in some cases.Which issue this PR fixes
fixes #2139
Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter]
)