[prometheus-json-exporter] fix: Multiple targets are now created as differently named ServiceMonitors #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itors. Signed-off-by: Felix <mail@freichert.de>
|
@schmiddim @zanhsieh Please approve running workflows. |
schmiddim
approved these changes
Jul 30, 2022
|
@fhreichert my approve does not count because of an error in the Code Owners File. |
monotek
approved these changes
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The chart now creates multiple, differently named, ServiceMonitors to allow for multiple targets to be scraped.
Which issue this PR fixes
Multiple targets did not create differently named ServiceMonitors resulting in the following error when defining more than one target:
Error: servicemonitors.monitoring.coreos.com "json-exporter-prometheus-json-exporter" already existsSpecial notes for your reviewer:
None
Checklist
[prometheus-couchdb-exporter])