[prometheus-postgres-exporter] Add possibility to have hostAliases defined in deployment spec #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fined in deployment spec Signed-off-by: Arthur Legrand <artlegrand@live.ca>
monotek
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arthur Legrand artlegrand@live.ca
What this PR does / why we need it
This is useful for people like me who use Google Cloud SQL Proxy as a sidecar to connect to the postgres server.
Since it's a side car, the exporter sees the server as
127.0.0.1which isn't very descriptive for many reasons, especially if you start having multiple PG Exporters for multiple servers.Bumped the minor version of the chart as this adds a functionality in a backwards compatible manner.
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])