[kube-prometheus-stack] Add flag to disable all exporters #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcpunk
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
|
Hi @jcpunk, can you please resolve conflicts and bump minor instead? This is adding a feature. Thank you! |
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
jcpunk
force-pushed
the
disable-exporters
branch
from
09db9fc
to
ef9534e
Compare
|
In theory that is sorted. |
GMartinez-Sisti
approved these changes
Apr 21, 2023
Matiasmct
pushed a commit
to giffgaff/prometheus-charts
that referenced
this pull request
May 16, 2023
…-community#3256) Signed-off-by: Pat Riehecky <riehecky@fnal.gov> Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
There are a handful of exporters shipping with this chart. If new ones are added over time, folks who are opting out may get them by mistake. A top level flag to control all of them provides an easy way to specify folks want opt out of all exporters.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])