[prometheus-pushgateway] Remove label duplication #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karlis Akots Gribulis <karlis.gribulis@gmail.com>
KarlisAG
changed the title
KarlisAG
changed the title
zanhsieh
previously approved these changes
May 4, 2023
Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>
Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>
zeritti
approved these changes
May 8, 2023
Matiasmct
pushed a commit
to giffgaff/prometheus-charts
that referenced
this pull request
May 16, 2023
…ty#3266) * Remove label duplication and bump chart Signed-off-by: Karlis Akots Gribulis <karlis.gribulis@gmail.com> * Bump version number Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> --------- Signed-off-by: Karlis Akots Gribulis <karlis.gribulis@gmail.com> Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Co-authored-by: MH <zanhsieh@gmail.com> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Remove label duplication from Deployment and StatefulSet, which occurs if
podLabelsare used. In that case the respective workload pod gets the same label twice because not only ispodLabelshardcoded in the workload manifest but also it gets the same labels fromprometheus-pushgateway.defaultLabelsfrom_helpers.tpl.While that mostly is just a nuisance it actually stops and fails HelmRelease in Flux as it is configured to fail if the same label is spotted twice on a resource.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])