[kube-prometheus-stack] add prometheus config reloader liveness and readiness prob…

[dongjiang1989]

…e setting

[ENHANCEMENT] Add optional liveness and readiness probes to prometheus-config-reloader. This can be enabled via the --enable-config-reloader-probes CLI flag. prometheus-operator/prometheus-operator#5449

prometheus-operator releases in v0.65.0 version

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• fixes #

Special notes for your reviewer

Checklist

• DCO signed
• Chart Version bumped
• Title of the PR starts with chart name (e.g. [kube-prometheus-stack])

[dongjiang1989]

@GMartinez-Sisti PTAL!

[onedr0p]

Shouldn't this have been a major upgrade since two new CRDs were added to Prometheus Operator since 0.63.0 and then documented in the README as such to apply them?

I am talking about monitoring.coreos.com_scrapeconfigs and monitoring.coreos.com_prometheusagents

[GMartinez-Sisti]

Shouldn't have this been a major upgrade since two new CRDs were added to Prometheus Operator since 0.63.0 and then documented in the README as such to apply them?

I am talking about the monitoring.coreos.com_scrapeconfigs and monitoring.coreos.com_prometheusagents crds.

Thanks for the input @onedr0p. From what I understood, they are backwards compatible. My understanding is due to these two lines on the changelog:

NOTE: if these conditions aren't met, the operator will start but it won't be able to reconcile the ScrapeConfig resources.

[BUGFIX] Don't start the PrometheusAgent controller if the CRD isn't present or the operator lacks permissions.

So until we add them to this helm chart, they just won't work and can't be used. WDYT?

[onedr0p]

To stay consistent I believe they should have been included in this release but now we might need to add them and do a major upgrade anyways.

[QuentinBisson]

There is a major version coming (I will have to upgrade to 0.65.1) but this is not as trivial as we are going over a kubernetes limitation: #3267

[mikejoh]

This is so confusing, so this PR bumped the appVersion to v0.65.1 but should've been done during a major bump of the kube-prometheus-stack chart? Nothing in this PR should've led to the appVersion bump, or am I missing something?

[QuentinBisson]

Nothing should have led to it but it is not a breaking change as the old CRDs can work as is with this version of the prometheus-operator. We are currently trying to upgrade the CRDs and make it a major version but the new CRDs are causing issues in regards to Kubernetes Secret limit #3267

[mikejoh]

Nothing should have led to it but it is not a breaking change as the old CRDs can work as is with this version of the prometheus-operator. We are currently trying to upgrade the CRDs and make it a major version but the new CRDs are causing issues in regards to Kubernetes Secret limit #3267

I think understand! A major bump of the chart, when the app version of the operator is bumped, isn't always needed - it depends as always! And thanks for the quick reply!