[kube-prometheus-stack] fix reloader-web's app protocol #3762

abaguas · 2023-09-05T19:37:38Z

What this PR does / why we need it

To integrate this port with applications such as istio the applicationProtocol should be set explicitly.
One solution to enable this integration is to add an appProtocol attribute to the port as explained in the Kubernetes documentation and implemented in this PR. Another alternative is to prefix the port with http-.

Checklist

DCO signed
Chart Version bumped
Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

abaguas · 2023-09-05T19:39:06Z

If preferred I can rename the port to http-reloader-web or add the appProtocol to the other http ports.
Just let me know

GMartinez-Sisti · 2023-09-06T11:11:20Z

Hi @abaguas! Thank you for the contribution 🙏

Looks like the appProtocol feature graduated on K8S 1.20, since we support 1.19 it would be nice to have some validation before adding it. Maybe something like this to append it conditionally:

helm-charts/charts/kube-prometheus-stack/templates/_helpers.tpl

Lines 170 to 179 in 3352ef8

    
           {{/* Get Ingress API Version */}} 
        
           {{- define "kube-prometheus-stack.ingress.apiVersion" -}} 
        
             {{- if and (.Capabilities.APIVersions.Has "networking.k8s.io/v1") (semverCompare ">= 1.19-0" (include "kube-prometheus-stack.kubeVersion" .)) -}} 
        
                 {{- print "networking.k8s.io/v1" -}} 
        
             {{- else if .Capabilities.APIVersions.Has "networking.k8s.io/v1beta1" -}} 
        
               {{- print "networking.k8s.io/v1beta1" -}} 
        
             {{- else -}} 
        
               {{- print "extensions/v1beta1" -}} 
        
             {{- end -}} 
        
           {{- end -}}

WDYT?

abaguas · 2023-09-06T20:24:45Z

Makes sense, thank you for the tip. I implemented it and tested with

$ helm package . && helm template kube-prometheus-stack kube-prometheus-stack-50.3.2.tgz -n monitoring --set kubeTargetVersionOverride="1.19.0" > manifests.yaml      
$ helm package . && helm template kube-prometheus-stack kube-prometheus-stack-50.3.2.tgz -n monitoring --set kubeTargetVersionOverride="1.20.0" > manifests-after.yaml
$ diff manifests.yaml manifests-after.yaml 
1389a1390
>     appProtocol: http
1584a1586
>     appProtocol: http

QuentinBisson · 2023-09-11T07:53:57Z

charts/kube-prometheus-stack/templates/prometheus/service.yaml

@@ -43,6 +43,10 @@ spec:
    port: {{ .Values.prometheus.service.port }}
    targetPort: {{ .Values.prometheus.service.targetPort }}
  - name: reloader-web
+    {{- $kubeTargetVersion := default .Capabilities.KubeVersion.GitVersion .Values.kubeTargetVersionOverride }}


Could you move this at the top?

Otherwise looks good

QuentinBisson · 2023-09-12T07:54:04Z

@abaguas Can you sign your commits?

Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com>

Signed-off-by: André Águas <abaguas@users.noreply.github.com>

abaguas · 2023-09-12T11:10:50Z

@abaguas Can you sign your commits?

@QuentinBisson done, looks green now.
Sorry for the force-push mess. This week I only have my work computer with me, on which I use a different login so I struggled a bit to amend past commits in the UI and GithubDesktop.
Anyway, it looks good now. Thank you for the review!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [kube-prometheus-stack](https://togithub.com/prometheus-community/helm-charts) | major | `48.6.0` -> `51.8.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus-community/helm-charts (kube-prometheus-stack)</summary> ### [`v51.8.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.8.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. ##### What's Changed - \[kube-prometheus-stack] Fix IO panels in Cluster Overview by [@jkroepke](https://togithub.com/jkroepke) in [prometheus-community/helm-charts#3902 **Full Changelog**: prometheus-community/helm-charts@prometheus-json-exporter-0.7.2...kube-prometheus-stack-51.8.0 ### [`v51.7.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.7.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Allow to configure keep_firing_for for all Prometheus rules by [@jkroepke](https://togithub.com/jkroepke) in [prometheus-community/helm-charts#3890 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.6.1...kube-prometheus-stack-51.7.0 ### [`v51.6.1`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.6.1) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] - bump thanos to 0.32.4 by [@DrFaust92](https://togithub.com/DrFaust92) in [prometheus-community/helm-charts#3885 **Full Changelog**: prometheus-community/helm-charts@prometheus-rabbitmq-exporter-1.9.0...kube-prometheus-stack-51.6.1 ### [`v51.6.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.6.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] hack: fix etcd mixin by [@jkroepke](https://togithub.com/jkroepke) in [prometheus-community/helm-charts#3880 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.5.3...kube-prometheus-stack-51.6.0 ### [`v51.5.3`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.5.3) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] bump thanos to 0.32.3 by [@DrFaust92](https://togithub.com/DrFaust92) in [prometheus-community/helm-charts#3845 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.5.2...kube-prometheus-stack-51.5.3 ### [`v51.5.2`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.5.2) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack]: fix thanos ruler alertmanager configs by [@thameezb](https://togithub.com/thameezb) in [prometheus-community/helm-charts#3870 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.5.1...kube-prometheus-stack-51.5.2 ### [`v51.5.1`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.5.1) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] bump prometheus image tag to 2.47.1 by [@FlorisFeddema](https://togithub.com/FlorisFeddema) in [prometheus-community/helm-charts#3877 #### New Contributors - [@FlorisFeddema](https://togithub.com/FlorisFeddema) made their first contribution in [prometheus-community/helm-charts#3877 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.5.0...kube-prometheus-stack-51.5.1 ### [`v51.5.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.5.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] bump windows rules and dashboards by [@TheKangaroo](https://togithub.com/TheKangaroo) in [prometheus-community/helm-charts#3818 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.4.1...kube-prometheus-stack-51.5.0 ### [`v51.4.1`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.4.1) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Bump dependencies by [@jkroepke](https://togithub.com/jkroepke) in [prometheus-community/helm-charts#3876 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.4.0...kube-prometheus-stack-51.4.1 ### [`v51.4.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.4.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] updated kube-state-metrics to 5.14.x by [@dotdc](https://togithub.com/dotdc) in [prometheus-community/helm-charts#3873 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.3.0...kube-prometheus-stack-51.4.0 ### [`v51.3.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.3.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] lift to grafana helm-chart version 6.60 by [@YuleZ](https://togithub.com/YuleZ) in [prometheus-community/helm-charts#3864 #### New Contributors - [@YuleZ](https://togithub.com/YuleZ) made their first contribution in [prometheus-community/helm-charts#3864 **Full Changelog**: prometheus-community/helm-charts@kube-state-metrics-5.14.0...kube-prometheus-stack-51.3.0 ### [`v51.2.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.2.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Add support for attaching node metadata by [@zeritti](https://togithub.com/zeritti) in [prometheus-community/helm-charts#3820 **Full Changelog**: prometheus-community/helm-charts@prometheus-statsd-exporter-0.10.1...kube-prometheus-stack-51.2.0 ### [`v51.1.1`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.1.1) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] fix: use correct job name for dashboards to work, make deployment more intuitively by [@lippertmarkus](https://togithub.com/lippertmarkus) in [prometheus-community/helm-charts#3672 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.1.0...kube-prometheus-stack-51.1.1 ### [`v51.1.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.1.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] remove default cpu and memory requests and li… by [@mmianl](https://togithub.com/mmianl) in [prometheus-community/helm-charts#3813 #### New Contributors - [@mmianl](https://togithub.com/mmianl) made their first contribution in [prometheus-community/helm-charts#3813 **Full Changelog**: prometheus-community/helm-charts@prometheus-25.0.0...kube-prometheus-stack-51.1.0 ### [`v51.0.3`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.0.3) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Adding operating systems values for node exporter by [@nicon89](https://togithub.com/nicon89) in [prometheus-community/helm-charts#3778 #### New Contributors - [@nicon89](https://togithub.com/nicon89) made their first contribution in [prometheus-community/helm-charts#3778 **Full Changelog**: prometheus-community/helm-charts@prometheus-node-exporter-4.23.1...kube-prometheus-stack-51.0.3 ### [`v51.0.2`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.0.2) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] fix reloader-web's app protocol by [@abaguas](https://togithub.com/abaguas) in [prometheus-community/helm-charts#3762 #### New Contributors - [@abaguas](https://togithub.com/abaguas) made their first contribution in [prometheus-community/helm-charts#3762 **Full Changelog**: prometheus-community/helm-charts@prometheus-pushgateway-2.4.1...kube-prometheus-stack-51.0.2 ### [`v51.0.1`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.0.1) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] fix prometheus-operator cilium netpol when using TLS by [@hervenicol](https://togithub.com/hervenicol) in [prometheus-community/helm-charts#3788 #### New Contributors - [@hervenicol](https://togithub.com/hervenicol) made their first contribution in [prometheus-community/helm-charts#3788 **Full Changelog**: prometheus-community/helm-charts@prometheus-kafka-exporter-2.5.0...kube-prometheus-stack-51.0.1 ### [`v51.0.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.0.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] operator bump to 0.68.0 by [@DrFaust92](https://togithub.com/DrFaust92) in [prometheus-community/helm-charts#3770 **Full Changelog**: prometheus-community/helm-charts@prometheus-cloudwatch-exporter-0.25.2...kube-prometheus-stack-51.0.0 ### [`v50.3.1`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-50.3.1) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] fix thanos sidecar ingress by [@DrFaust92](https://togithub.com/DrFaust92) in [prometheus-community/helm-charts#3756 **Full Changelog**: prometheus-community/helm-charts@prometheus-24.2.0...kube-prometheus-stack-50.3.1 ### [`v50.3.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-50.3.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] regenerate grafana dashboards by [@DrFaust92](https://togithub.com/DrFaust92) in [prometheus-community/helm-charts#3757 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-50.2.0...kube-prometheus-stack-50.3.0 ### [`v50.2.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-50.2.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Generate latest alerts by [@DrFaust92](https://togithub.com/DrFaust92) in [prometheus-community/helm-charts#3753 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-50.1.0...kube-prometheus-stack-50.2.0 ### [`v50.1.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-50.1.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] bump kube-state-metrics and prometheus-node-exporter by [@DrFaust92](https://togithub.com/DrFaust92) in [prometheus-community/helm-charts#3752 **Full Changelog**: prometheus-community/helm-charts@prometheus-node-exporter-4.23.0...kube-prometheus-stack-50.1.0 ### [`v50.0.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-50.0.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Bump minimun kubeVersion to ">=1.19.0-0" by [@arukiidou](https://togithub.com/arukiidou) in [prometheus-community/helm-charts#3606 **Full Changelog**: prometheus-community/helm-charts@kube-state-metrics-5.12.1...kube-prometheus-stack-50.0.0 ### [`v49.2.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-49.2.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Add support for relabelings and metricRelabelings by [@Jonnobrow](https://togithub.com/Jonnobrow) in [prometheus-community/helm-charts#3683 #### New Contributors - [@Jonnobrow](https://togithub.com/Jonnobrow) made their first contribution in [prometheus-community/helm-charts#3683 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-49.1.0...kube-prometheus-stack-49.2.0 ### [`v49.1.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-49.1.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Updates thanos image to v0.32.1 by [@arukiidou](https://togithub.com/arukiidou) in [prometheus-community/helm-charts#3735 **Full Changelog**: prometheus-community/helm-charts@prometheus-24.0.0...kube-prometheus-stack-49.1.0 ### [`v49.0.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-49.0.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Upgrade crds to 0.67.1 by [@EtienneBarbier](https://togithub.com/EtienneBarbier) in [prometheus-community/helm-charts#3668 **Full Changelog**: prometheus-community/helm-charts@prometheus-mongodb-exporter-3.3.0...kube-prometheus-stack-49.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/spiceratops/k8s-gitops).

…ommunity#3762) * [kube-prometheus-stack] fix reloader-web's app protocol Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> * guard appProtocol with target kubernetes version check Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> * Move kubeTargetVersion to top of file Signed-off-by: André Águas <abaguas@users.noreply.github.com> * Move kubeTargetVersion to top of file Signed-off-by: André Águas <abaguas@users.noreply.github.com> --------- Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> Signed-off-by: André Águas <abaguas@users.noreply.github.com>

abaguas requested review from andrewgkew, gianrubio, gkarthiks, GMartinez-Sisti, QuentinBisson, scottrigby and Xtigyro as code owners September 5, 2023 19:37

QuentinBisson reviewed Sep 11, 2023

View reviewed changes

QuentinBisson previously approved these changes Sep 12, 2023

View reviewed changes

[kube-prometheus-stack] fix reloader-web's app protocol

3494bf4

Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com>

abaguas requested review from desaintmartin, jkroepke, steven-sheehy, zeritti, asherf, torstenwalter, naseemkullah, zanhsieh, dotdc, mrueg and tariq1890 as code owners September 12, 2023 10:53

guard appProtocol with target kubernetes version check

ab2638a

Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com>

abaguas dismissed QuentinBisson’s stale review via d149406 September 12, 2023 11:01

abaguas added 3 commits September 12, 2023 13:04

Move kubeTargetVersion to top of file

a46b028

Signed-off-by: André Águas <abaguas@users.noreply.github.com>

Move kubeTargetVersion to top of file

52f3da9

Signed-off-by: André Águas <abaguas@users.noreply.github.com>

Merge branch 'main' into main

602dfaf

Signed-off-by: André Águas <abaguas@users.noreply.github.com>

QuentinBisson approved these changes Sep 12, 2023

View reviewed changes

QuentinBisson merged commit c0c87f0 into prometheus-community:main Sep 12, 2023
4 checks passed

renovate bot mentioned this pull request Sep 12, 2023

Update all dependencies nolte/k8s-home-lab#755

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[kube-prometheus-stack] fix reloader-web's app protocol #3762

[kube-prometheus-stack] fix reloader-web's app protocol #3762

abaguas commented Sep 5, 2023 •

edited

abaguas commented Sep 5, 2023 •

edited

GMartinez-Sisti commented Sep 6, 2023

abaguas commented Sep 6, 2023

QuentinBisson Sep 11, 2023

QuentinBisson Sep 11, 2023

QuentinBisson commented Sep 12, 2023

abaguas commented Sep 12, 2023

[kube-prometheus-stack] fix reloader-web's app protocol #3762

[kube-prometheus-stack] fix reloader-web's app protocol #3762

Conversation

abaguas commented Sep 5, 2023 • edited

What this PR does / why we need it

Checklist

abaguas commented Sep 5, 2023 • edited

GMartinez-Sisti commented Sep 6, 2023

abaguas commented Sep 6, 2023

QuentinBisson Sep 11, 2023

Choose a reason for hiding this comment

QuentinBisson Sep 11, 2023

Choose a reason for hiding this comment

QuentinBisson commented Sep 12, 2023

abaguas commented Sep 12, 2023

abaguas commented Sep 5, 2023 •

edited

abaguas commented Sep 5, 2023 •

edited