[prometheus-adapter] Allow configuration of startupProbe #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Mo <kevin.mo@frontapp.com>
kevinmo13
requested review from
hectorj2f,
MattiasGees and
steven-sheehy
as code owners
steven-sheehy
requested changes
Sep 29, 2023
kevinmo13
force-pushed
the
kmo/startup-probe
branch
from
71c35d9
to
7065330
Compare
Signed-off-by: Kevin Mo <kevin.mo@frontapp.com>
Signed-off-by: Kevin Mo <kevin.mo@frontapp.com>
kevinmo13
force-pushed
the
kmo/startup-probe
branch
from
7065330
to
70db211
Compare
steven-sheehy
requested changes
Oct 3, 2023
Co-authored-by: Steven Sheehy <17552371+steven-sheehy@users.noreply.github.com> Signed-off-by: Kevin Mo <kevin.mo@frontapp.com>
steven-sheehy
approved these changes
Oct 3, 2023
|
Thanks for the reviews and helping to get this change through! |
Matiasmct
pushed a commit
to giffgaff/prometheus-charts
that referenced
this pull request
Mar 20, 2024
…community#3811) Signed-off-by: Kevin Mo <kevin.mo@frontapp.com> Co-authored-by: Steven Sheehy <17552371+steven-sheehy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
prometheus-adapter polls for all API version on startup, and we are running crossplane which creates ~1000 CRDs. Configuring a startup probe avoids killing the pod due to timeout.
Which issue this PR fixes
N/A
Special notes for your reviewer
N/A
Checklist
[prometheus-couchdb-exporter])